agavra commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1021916211
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -257,13 +257,15 @@ private static List<String>
toH2FieldNamesAndTypes(org.apache.pinot.spi.data.Sch
public static class QueryTestCase {
@JsonProperty("sql")
- public String _sql;
+ public List<String> _sql;
Review Comment:
suggestion: I think it might be better to model it like:
```
{
"tables": [..],
"inputs": {...},
"tests": [
{
"description": "",
"sql": "...",
"outputs": [...]
},
{
"description": "",
"sql": "...",
"outputs": [...]
}
]
}
```
I think that'll be much easier to handle (both in the code and when we want
to make changes going forward). I also don't know how that shows up in IntelliJ
- but this will make it clear that every element within `tests` is a single
test case in TestNG. It also lets us have the same setup where part of it uses
H2 and others don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
