walterddr commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1021860041
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,40 @@
+{
+ "special_syntax": {
+ "description": "test special syntax that cannot be supported by reference
engine",
+ "sql": [
+ "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col1)",
+ "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING (col2)"
+ ],
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
+ ["foo", "alice", 1],
+ ["bar", "bob", 2]
+ ],
+ "tbl2": [
+ ["foo", "bob", 3],
+ ["alice", "alice", 4]
+ ]
+ },
+ "outputs": [
+ [
+ ["foo", 3]
+ ],
+ [
+ ["bar", 3],
+ ["foo", 4]
+ ]
+ ]
+ }
+}
Review Comment:
```suggestion
}
```
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -257,13 +257,15 @@ private static List<String>
toH2FieldNamesAndTypes(org.apache.pinot.spi.data.Sch
public static class QueryTestCase {
@JsonProperty("sql")
- public String _sql;
+ public List<String> _sql;
Review Comment:
got it. let me try to remodel (best do it first, otherwise need lots of json
refactoring later)
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,40 @@
+{
+ "special_syntax": {
+ "description": "test special syntax that cannot be supported by reference
engine",
Review Comment:
```suggestion
"special_join_syntax": {
"description": "test special join syntax that cannot be supported by
reference H2 engine",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
