walterddr commented on code in PR #9794:
URL: https://github.com/apache/pinot/pull/9794#discussion_r1022063405
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
+ ["foo", "alice", 1],
+ ["bar", "bob", 2]
+ ],
+ "tbl2": [
+ ["foo", "bob", 3],
+ ["alice", "alice", 4]
+ ]
+ },
+ "queries": [
+ {
+ "description": "test join with using clause",
+ "sql": "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING
(col1)",
+ "outputs": [
+ ["foo", 3]
+ ]
+ },
+ {
+ "description": "test join with using clause but join with columns not
being selected",
+ "sql": "SELECT {tbl1}.col1, {tbl2}.col3 FROM {tbl1} JOIN {tbl2} USING
(col2)",
+ "outputs": [
Review Comment:
yeah this is a good question. we will add a alias/column reference test json
separately to test these
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
Review Comment:
yes
##########
pinot-query-runtime/src/test/resources/queries/SpecialSyntax.json:
##########
@@ -0,0 +1,43 @@
+{
+ "special_syntax": {
+ "tables": {
+ "tbl1": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ],
+ "tbl2": [
+ {"name": "col1", "type": "STRING"},
+ {"name": "col2", "type": "STRING"},
+ {"name": "col3", "type": "INT"}
+ ]
+ },
+ "inputs": {
+ "tbl1": [
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
