agavra commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1037547569
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -165,28 +165,31 @@ private TransferableBlock produceAggregatedBlock() {
*/
private boolean consumeInputBlocks() {
TransferableBlock block = _inputOperator.nextBlock();
- // setting upstream error block
- if (block.isErrorBlock()) {
- _upstreamErrorBlock = block;
- return true;
- } else if (block.isEndOfStreamBlock()) {
- _readyToConstruct = true;
- return true;
- }
+ while (!block.isNoOpBlock()) {
Review Comment:
what do you mean by this? the last line of the loop gets the next block from
upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
