agavra commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1037556817
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -165,28 +165,31 @@ private TransferableBlock produceAggregatedBlock() {
*/
private boolean consumeInputBlocks() {
TransferableBlock block = _inputOperator.nextBlock();
- // setting upstream error block
- if (block.isErrorBlock()) {
- _upstreamErrorBlock = block;
- return true;
- } else if (block.isEndOfStreamBlock()) {
- _readyToConstruct = true;
- return true;
- }
+ while (!block.isNoOpBlock()) {
Review Comment:
yup! that makes the scheduling logic much simpler because as soon as I
schedule I know that I have no more mail I need to hold on to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
