61yao commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1040011730
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemoryReceivingMailbox.java:
##########
@@ -19,38 +19,40 @@
package org.apache.pinot.query.mailbox;
import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.TimeUnit;
import org.apache.pinot.query.runtime.blocks.TransferableBlock;
public class InMemoryReceivingMailbox implements
ReceivingMailbox<TransferableBlock> {
- private final String _mailboxId;
+ private final String _stringMailboxId;
private final BlockingQueue<TransferableBlock> _queue;
+ private final MailboxIdentifier _mailboxId;
private volatile boolean _closed;
public InMemoryReceivingMailbox(String mailboxId,
BlockingQueue<TransferableBlock> queue) {
- _mailboxId = mailboxId;
+ _stringMailboxId = mailboxId;
+ _mailboxId = new StringMailboxIdentifier(_stringMailboxId);
Review Comment:
nit: not needed anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
