agavra commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1041201080
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperator.java:
##########
@@ -134,6 +138,7 @@ protected TransferableBlock getNextBlock() {
int startingIdx = _serverIdx;
int openMailboxCount = 0;
+ int eosMailboxCount = 0;
Review Comment:
i think this code is easier to read as is - one variable for "the number of
mailboxes opened" and one for "the number of EOS received". It isn't
immediately clear why I should decrement the first when I get the second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
