walterddr commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1041188285
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -126,18 +126,24 @@ protected TransferableBlock getNextBlock() {
TransferableBlock transferableBlock;
try {
transferableBlock = _dataTableBlockBaseOperator.nextBlock();
+ while (!transferableBlock.isNoOpBlock()) {
+ _exchange.send(transferableBlock);
+
+ if (transferableBlock.isEndOfStreamBlock()) {
+ return transferableBlock;
+ }
+
+ transferableBlock = _dataTableBlockBaseOperator.nextBlock();
+ }
} catch (final Exception e) {
// ideally, MailboxSendOperator doesn't ever throw an exception because
// it will just get swallowed, in this scenario at least we can forward
// any upstream exceptions as an error block
transferableBlock = TransferableBlockUtils.getErrorTransferableBlock(e);
- }
-
- if (!TransferableBlockUtils.isNoOpBlock(transferableBlock)) {
try {
_exchange.send(transferableBlock);
- } catch (Exception e) {
- LOGGER.error("Exception while sending block to mailbox.", e);
+ } catch (Exception e2) {
+ LOGGER.error("Exception while sending block to mailbox.", e2);
Review Comment:
e2? meaning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
