agavra commented on code in PR #9887:
URL: https://github.com/apache/pinot/pull/9887#discussion_r1041243571
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/ChannelManager.java:
##########
@@ -41,9 +43,11 @@ public class ChannelManager {
private final ConcurrentHashMap<String, ManagedChannel> _channelMap = new
ConcurrentHashMap<>();
- public ChannelManager(GrpcMailboxService mailboxService, PinotConfiguration
extraConfig) {
+ public ChannelManager(GrpcMailboxService mailboxService, PinotConfiguration
extraConfig,
+ Consumer<MailboxIdentifier> gotMailCallback) {
_mailboxService = mailboxService;
- _grpcMailboxServer = new GrpcMailboxServer(_mailboxService,
_mailboxService.getMailboxPort(), extraConfig);
+ _grpcMailboxServer = new GrpcMailboxServer(
+ _mailboxService, _mailboxService.getMailboxPort(), extraConfig,
gotMailCallback);
Review Comment:
I see what you are saying and I think this makes sense, since this isn't a
minor code refactoring (most of the PR is just piping this through) - do you
mind if I do that as a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
