siddharthteotia commented on PR #9930: URL: https://github.com/apache/pinot/pull/9930#issuecomment-1341628581
> > I am guessing we can use this to compare performance and even correctness between `broadcast join` , `shuffle join`, `colocated partitioning` table join ? > > I guess pretty much any scenario where we force the plan to not have an exchange ? > > SkipShuffle is mostly used for doing colocated table join today. The main purpose is to compare colocated partitioning join and not. > > > Another question - are we using `shuffle` and `exchange` terminology interchangeably ? IIRC, this was the case on the original design docs. > > So when we say `shuffle` is disabled, does that mean shuffle based exchange is disabled (but broadcast exchange can happen) or `exchange` all together is disabled ? > > Disable is for disable SkipShuffle optimizer. SkipShuffle here means we are still doing exchange. but we are changing the broadcast exchange to singleton to favor local exchange. (we are already seeing problems caused by SkipShuffle and considering removing it all together ) Got it !! Makes sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
