walterddr commented on PR #9930: URL: https://github.com/apache/pinot/pull/9930#issuecomment-1341747425
> > let's remove all skipShuffle usage for now. (keep the shuffle rewrite, some of the logics are valid. just the modification to singleton exchange is not desired) > > How about I change the default behavior to be disabled and enabled only requested? So we can use it when we think it is correct and understand the perf gain by this? yeah disabling the shuffle rewrite is good enough for now. no need to create an option for turning this on and off. for 2 reasons 1. we don't know how this is going to be used once we incorporated worker assignment strategy plugin 2. turning the current skipshuffle only works on a single 2 table join followed by a group by with the same key on the left table, which is severely limited. 3. creating a option here causes backward compatibility issues esp. we are close to a 0.12 release cut. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
