Jackie-Jiang commented on code in PR #9977:
URL: https://github.com/apache/pinot/pull/9977#discussion_r1050244666
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -65,8 +65,21 @@ protected static PinotDataBufferMemoryManager
getMemoryManager(String consumerDi
* @return Per-partition consumer's status, which typically includes last
consumed message timestamp,
* latest available upstream offset etc
*/
- public abstract Map<String, ConsumerPartitionState>
getConsumerPartitionState();
+ public abstract Map<String, ConsumerPartitionState>
getConsumerPartitionState(boolean skipOffsetLag);
Review Comment:
Is this change related? I feel this is more like a performance optimization
to avoid always fetching latest offset?
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java:
##########
@@ -437,6 +442,11 @@ public Map<String, PartitionLagState>
getPartitionToLagState(
throw new UnsupportedOperationException();
}
+ @Override
+ public void handleConsumptionStatus(boolean caughtUp) {
Review Comment:
Suggest renaming it to `notifyConsumptionCaughtUp()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
