gortiz commented on PR #9977: URL: https://github.com/apache/pinot/pull/9977#issuecomment-1357228195
I'm not against the feature but as said, I don't understand why we need it. Kafka already exports the replication lag for each consumer. They are exported in JMX right now and the only thing we need to read it is to add it to the prometheus yml file. I've been talking with Navina and it seems that consumers export metrics classifying them by consumer.id, which right now is a random value, but we could change it to be the name of the server plus the table, so we can classify that. It may be the case that we need to add some extra metrics but: 1. We should study whether that new metric can be useful to third parties, in such case it may be introduced in Kafka itself 2. I don't think we should make PinotMetricRegistry plugable, as I explained [here](https://github.com/apache/pinot/issues/8762) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
