navina commented on code in PR #9977:
URL: https://github.com/apache/pinot/pull/9977#discussion_r1050939027
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -65,8 +65,21 @@ protected static PinotDataBufferMemoryManager
getMemoryManager(String consumerDi
* @return Per-partition consumer's status, which typically includes last
consumed message timestamp,
* latest available upstream offset etc
*/
- public abstract Map<String, ConsumerPartitionState>
getConsumerPartitionState();
+ public abstract Map<String, ConsumerPartitionState>
getConsumerPartitionState(boolean skipOffsetLag);
Review Comment:
It is related. We don't want to fetch latest offset every time we emit
metrics. This would put unusual load on the source broker since we will make
#replica calls for each topic partition individually.
I would think of it more like safety - Pinot should not kill the source
broker. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
