andiem-bq commented on code in PR #10266:
URL: https://github.com/apache/pinot/pull/10266#discussion_r1106119798
##########
pinot-common/src/test/java/org/apache/pinot/common/function/FunctionDefinitionRegistryTest.java:
##########
@@ -42,9 +42,9 @@ public class FunctionDefinitionRegistryTest {
);
private static final List<String> IGNORED_FUNCTION_NAMES = ImmutableList.of(
// functions we are not supporting post transform anyway
- "valuein", "mapvalue", "inidset", "lookup", "groovy", "scalar",
"geotoh3", "case", "not_in", "timeconvert",
+ "valuein", "mapvalue", "inidset", "lookup", "groovy", "scalar",
"geotoh3", "not_in", "timeconvert",
// functions not needed for register b/c they are in std sql table or
they will not be composed directly.
- "in", "and", "or", "not", "range", "extract"
Review Comment:
It looks like 'NOT' has been implemented and gets added to the function
registry. So removed it from the ignored list for the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
