andiem-bq commented on code in PR #10266:
URL: https://github.com/apache/pinot/pull/10266#discussion_r1107429515
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java:
##########
@@ -94,33 +94,41 @@ private static Object coalesceVar(Object... objects) {
return null;
}
- @ScalarFunction
- public static Object caseWhen(boolean c1, Object o1, Object oe) {
+ @Nullable
+ @ScalarFunction(nullableParameters = true, names = {"case", "caseWhen",
"case_when"})
Review Comment:
yes. we would like CASE WHEN to go to compile time invoker when theres only
literals and just go to transform function as usual otherwise.
We are able to get this with only adding the name case. Should we remove the
names caseWhen and case_when?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
