walterddr commented on code in PR #10266:
URL: https://github.com/apache/pinot/pull/10266#discussion_r1106529857
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ObjectFunctions.java:
##########
@@ -94,33 +94,41 @@ private static Object coalesceVar(Object... objects) {
return null;
}
- @ScalarFunction
- public static Object caseWhen(boolean c1, Object o1, Object oe) {
+ @Nullable
+ @ScalarFunction(nullableParameters = true, names = {"case", "caseWhen",
"case_when"})
Review Comment:
I see. so basically IIUC -->
- your expectation of `SELECT CASE WHEN 2 > 0 THEN 'YES' ELSE 'NO' END FROM
tbl` is to return a single row with `"YES"`, but now it returns multiple rows
of `"YES"` (in fact no. of row in tbl)
- you don't care about whether `CASEWHEN` syntax.
is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
