walterddr commented on code in PR #10434:
URL: https://github.com/apache/pinot/pull/10434#discussion_r1140628979
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -108,6 +107,18 @@ public void testQueryOptions()
h2Query, getH2Connection(), null, ImmutableMap.of("queryOptions",
"useMultistageEngine=true"));
}
+ @Test
+ public void testMultiValueColumnSelectionQuery()
+ throws Exception {
+ String pinotQuery =
+ "SELECT DivAirportIDs, DivAirports FROM mytable WHERE
DATE_TIME_CONVERT(DaysSinceEpoch, '1:DAYS:EPOCH', "
+ + "'1:DAYS:SIMPLE_DATE_FORMAT:yyyy-MM-dd''T''HH:mm:ss.SSS''Z''',
'1:DAYS') = '2014-09-05T00:00:00.000Z'";
+ String h2Query =
+ "SELECT DivAirportIDs__MV0, DivAirports__MV0 FROM mytable WHERE
DaysSinceEpoch = 16318 LIMIT 10000";
+ ClusterIntegrationTestUtils.testQueryWithMatchingRowCount(pinotQuery,
_brokerBaseApiUrl, getPinotConnection(),
+ h2Query, getH2Connection(), null, ImmutableMap.of("queryOptions",
"useMultistageEngine=true"));
Review Comment:
i am not sure this counts are full support and will cause issue. for example
if we do a group-by query. the behavior will be drastically different between
```
SELECT mvCol, count(*) FROM tbl GROUP BY mvCol -- this will still behave as
unnest
SELECT mvCol, count(*) FROM tblA JOIN tblB USING(key) GROUP BY mvCol --
this will use the entire array as group
```
also the ordering of a group is not guaranteed --> maybe we are better off
creating a ARRAY type in V1 that MV column can extend from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
