xiangfu0 commented on code in PR #10434:
URL: https://github.com/apache/pinot/pull/10434#discussion_r1142744672
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RelToStageConverter.java:
##########
@@ -151,34 +152,39 @@ private static DataSchema toDataSchema(RelDataType
rowType) {
}
public static DataSchema.ColumnDataType convertToColumnDataType(RelDataType
relDataType) {
- switch (relDataType.getSqlTypeName()) {
+ SqlTypeName sqlTypeName = relDataType.getSqlTypeName();
+ boolean isArray = sqlTypeName == SqlTypeName.ARRAY;
Review Comment:
From what I've read from here:
https://calcite.apache.org/javadocAggregate/org/apache/calcite/sql/type/SqlTypeName.html
Seems Array is the type.
For future extensibility, we can make this call recursive to construct the
recursive DataType for Complex/nest data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
