siddharthteotia commented on code in PR #10434:
URL: https://github.com/apache/pinot/pull/10434#discussion_r1140976431


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RelToStageConverter.java:
##########
@@ -151,34 +152,39 @@ private static DataSchema toDataSchema(RelDataType 
rowType) {
   }
 
   public static DataSchema.ColumnDataType convertToColumnDataType(RelDataType 
relDataType) {
-    switch (relDataType.getSqlTypeName()) {
+    SqlTypeName sqlTypeName = relDataType.getSqlTypeName();
+    boolean isArray = sqlTypeName == SqlTypeName.ARRAY;

Review Comment:
   Here we are equating our current support of MV with `SqlTypeName.ARRAY`. Is 
`SqlTypeName.ARRAY` extendible in future to help handle complex LIST (list that 
may not necessarily have primitives only) ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to