ankitsultana commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1152320183
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotTable.java:
##########
@@ -37,16 +37,18 @@
*/
public class PinotTable extends AbstractTable implements ScannableTable {
private Schema _schema;
+ private boolean _enableNullSupport;
- public PinotTable(Schema schema) {
+ public PinotTable(Schema schema, boolean enableNullSupport) {
_schema = schema;
+ _enableNullSupport = enableNullSupport;
}
@Override
public RelDataType getRowType(RelDataTypeFactory relDataTypeFactory) {
Preconditions.checkState(relDataTypeFactory instanceof TypeFactory);
TypeFactory typeFactory = (TypeFactory) relDataTypeFactory;
- return typeFactory.createRelDataTypeFromSchema(_schema);
+ return typeFactory.createRelDataTypeFromSchema(_schema,
_enableNullSupport);
Review Comment:
Hmm.. we are essentially setting nullability at Table level right since we
are using `PinotTable._enableNullSupport`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
