ankitsultana commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1152436218
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -45,6 +45,7 @@
@SuppressWarnings("unused")
public abstract class FieldSpec implements Comparable<FieldSpec>, Serializable
{
public static final int DEFAULT_MAX_LENGTH = 512;
+ public static final boolean DEFAULT_NULLABILITY = false;
Review Comment:
So right now a lot of people must be using the table level
`enableNullHandling: true` config which creates null vectors in the segments.
Since those tables wouldn't have the field level nullability set, I guess
we'll set their nullability as false?
I think when we set `enableNullHandling: true` at table-level, it
effectively makes all the columns nullable, since:
1. You can do queries such as IS NULL/IS NOT NULL and they'll work correctly
(for v1 engine).
2. If you add the queryOption `enableNullHandling=true`, then Pinot will
also return actual nulls instead of the default null value. e.g. select
num_orders from table where num_orders is null will returns rows which look
like: `[null, null, ...]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
