walterddr commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1152500803
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##########
@@ -43,43 +43,44 @@ public TypeFactory(RelDataTypeSystem typeSystem) {
super(typeSystem);
}
- public RelDataType createRelDataTypeFromSchema(Schema schema) {
+ public RelDataType createRelDataTypeFromSchema(Schema schema, boolean
isNullSupportEnabled) {
Builder builder = new Builder(this);
for (Map.Entry<String, FieldSpec> e : schema.getFieldSpecMap().entrySet())
{
- builder.add(e.getKey(), toRelDataType(e.getValue()));
+ builder.add(e.getKey(), toRelDataType(e.getValue(),
+ isNullSupportEnabled || e.getValue().isNullableField()));
Review Comment:
no and to answer the previous comment as well.
we can either enable globally (using table config), or enable via column
config
- if global enable. then all fields are nullable.
- if not global enable. we read column level nullability.
- if neither is set, then the column is not nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
