mcvsubbu commented on PR #10451: URL: https://github.com/apache/pinot/pull/10451#issuecomment-1490783569
> @mcvsubbu There are pros and cons of storing the status within the IS: For pause/consume, it makes more sense to store the status within the IS because: > > * There is only one state associated with the table (a boolean flag pause) > * It is accessed quite frequently (not ad-hoc) > * We never need to access this flag for all tables > > For the controller task, IMO it makes more sense to keep the status into a separate ZNode because: > > * It is per task type node, instead of per table node > * All the access is ad-hoc (when manually submitting a task, or checking status) > * We want to know all the tasks (cross multiple tables) for a given task type Arguments make sense. I think the PR is including (or at least suggesting) that we try a new znode for forceCommit, and hence my questions. Note that forceCommit is built on pause/resume -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
