swaminathanmanish commented on code in PR #10451:
URL: https://github.com/apache/pinot/pull/10451#discussion_r1156401913
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -255,6 +255,8 @@ public PinotHelixResourceManager(ControllerConf
controllerConf) {
* as PARTICIPANT,
* which would be put to lead controller resource and mess up the leadership
assignment. Those places should use
* SPECTATOR other than PARTICIPANT.
+ * TODO:For the <a
href="https://github.com/apache/pinot/pull/10451";>backwards incompatible
change</a>, this is a
Review Comment:
cc @Jackie-Jiang
Yes, there's that window. We debated about the complexity of making it
backwards compatible Vs keeping it simple. If the controller is upgraded after
reload is initiated, we will not be able to get the reload status from the
upgraded controller (old controller will still be able to read the status).
Given this is a corner case, calling this backwards incompatible can warn users
doing a controller upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
