walterddr commented on code in PR #10451:
URL: https://github.com/apache/pinot/pull/10451#discussion_r1155062405
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -635,8 +635,8 @@ public ServerReloadControllerJobStatusResponse
getReloadJobStatus(
Map<String, List<String>> serverToSegments;
String singleSegmentName = null;
- if (controllerJobZKMetadata.get(CommonConstants.ControllerJob.JOB_TYPE)
- .equals(ControllerJobType.RELOAD_SEGMENT.toString())) {
+ if
(controllerJobZKMetadata.get(CommonConstants.ControllerJob.SEGMENT_RELOAD_JOB_SEGMENT_NAME)
+ != null) {
Review Comment:
curious why change the content of the controller zk metadata to use the
segment name for checking whether it is reloading 1 or all segments? what's the
pro/con putting the together vs separate?
just my opinion, i know they are related, but i dont foresee any
circumstances we will use the 2 types of reload together (maybe I am wrong
please definitely share your thoughts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
