xiangfu0 commented on code in PR #10515:
URL: https://github.com/apache/pinot/pull/10515#discussion_r1154111743
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java:
##########
@@ -139,13 +139,11 @@ public TransformResultMetadata getResultMetadata() {
@Override
public int[] transformToIntValuesSV(ValueBlock valueBlock) {
int length = valueBlock.getNumDocs();
-
- if (_intValuesSV == null) {
+ if (_intValuesSV == null || _intValuesSV.length < length) {
Review Comment:
Maybe have both methods:
```
initIntValuesSV(length);
initIntValuesSV(length, defaultValue);
```
in BaseTransformFunction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
