Jackie-Jiang commented on code in PR #10515:
URL: https://github.com/apache/pinot/pull/10515#discussion_r1154925954
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java:
##########
@@ -122,12 +121,16 @@ public int[][] transformToDictIdsMV(ValueBlock
valueBlock) {
throw new UnsupportedOperationException();
}
+ protected void initIntValuesSV(int length) {
+ if (_intValuesSV == null || _intValuesSV.length < length) {
Review Comment:
No because we use it as a reusable buffer to reduce the allocation. We'll
only read up to `length` values from the buffer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
