Jackie-Jiang commented on code in PR #10515:
URL: https://github.com/apache/pinot/pull/10515#discussion_r1154927319
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/GroovyTransformFunction.java:
##########
@@ -429,13 +408,11 @@ public double[][] transformToDoubleValuesMV(ValueBlock
valueBlock) {
@Override
public String[][] transformToStringValuesMV(ValueBlock valueBlock) {
- if (_stringValuesMV == null) {
- _stringValuesMV = new String[DocIdSetPlanNode.MAX_DOC_PER_CALL][];
- }
+ int length = valueBlock.getNumDocs();
+ initStringValuesMV(length);
Review Comment:
I'm pretty sure that is a typo (we used to always allocate 10K docs, but
then changed it to length)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
