somandal commented on code in PR #10534:
URL: https://github.com/apache/pinot/pull/10534#discussion_r1157673218
##########
pinot-broker/src/test/java/org/apache/pinot/broker/broker/BasicAuthAccessControlTest.java:
##########
@@ -101,6 +111,14 @@ public void testDeny() {
request.setQuerySource(source);
Assert.assertFalse(_accessControl.hasAccess(identity, request));
+
+ Set<String> tableNames = new HashSet<>();
+ tableNames.add("veryImportantStuff");
Review Comment:
is the objective here to test that each of these table names doesn't have
access? if so won't the `hasAccess` loop return false when it encounters the
first table without access? Just making sure this test does what's intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
