walterddr commented on code in PR #10534:
URL: https://github.com/apache/pinot/pull/10534#discussion_r1160410713
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -155,11 +160,22 @@ private BrokerResponse handleRequest(long requestId,
String query,
compilationStartTimeNs = System.nanoTime();
switch (sqlNodeAndOptions.getSqlNode().getKind()) {
case EXPLAIN:
- String plan = _queryEnvironment.explainQuery(query,
sqlNodeAndOptions);
+ queryPlanResult = _queryEnvironment.explainQuery(query,
sqlNodeAndOptions);
Review Comment:
there's no reason to send EXPLAIN PLAN to server since broker has all the
information the servers have in order to create the PLAN. the only information
on server is whether segment A has inverted index; and segment B doesn't have
it (e.g. it was generated with a different table config). and sending
per-segment level physical plan info back to user is neither necessary nor
practical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
