jackjlli commented on code in PR #10534:
URL: https://github.com/apache/pinot/pull/10534#discussion_r1159276203
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -155,11 +160,22 @@ private BrokerResponse handleRequest(long requestId,
String query,
compilationStartTimeNs = System.nanoTime();
switch (sqlNodeAndOptions.getSqlNode().getKind()) {
case EXPLAIN:
- String plan = _queryEnvironment.explainQuery(query,
sqlNodeAndOptions);
+ queryPlanResult = _queryEnvironment.explainQuery(query,
sqlNodeAndOptions);
Review Comment:
For `EXPLAIN` cases, shouldn't we consider deducting the qps quota for that?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -179,6 +225,7 @@ private BrokerResponse handleRequest(long requestId, String
query,
stageIdStatsMap.put(stageId, new ExecutionStatsAggregator(traceEnabled));
}
+ long executionStartTime = System.nanoTime();
Review Comment:
nit: rename it to `executionStartTimeNs` to make it clear. Same for the
other newly added variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
