Jackie-Jiang commented on code in PR #10451:
URL: https://github.com/apache/pinot/pull/10451#discussion_r1160130002
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -635,8 +635,8 @@ public ServerReloadControllerJobStatusResponse
getReloadJobStatus(
Map<String, List<String>> serverToSegments;
String singleSegmentName = null;
- if (controllerJobZKMetadata.get(CommonConstants.ControllerJob.JOB_TYPE)
- .equals(ControllerJobType.RELOAD_SEGMENT.toString())) {
+ if
(controllerJobZKMetadata.get(CommonConstants.ControllerJob.SEGMENT_RELOAD_JOB_SEGMENT_NAME)
+ != null) {
// No need to query servers where this segment is not supposed to be
hosted
singleSegmentName =
controllerJobZKMetadata.get(CommonConstants.ControllerJob.SEGMENT_RELOAD_JOB_SEGMENT_NAME);
Review Comment:
Can be simplified:
```
String singleSegmentName =
controllerJobZKMetadata.get(CommonConstants.ControllerJob.SEGMENT_RELOAD_JOB_SEGMENT_NAME);
if (singleSegmentName != null) {
...
```
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2162,11 +2163,11 @@ public boolean addNewReloadAllSegmentsJob(String
tableNameWithType, String jobId
Map<String, String> jobMetadata = new HashMap<>();
jobMetadata.put(CommonConstants.ControllerJob.JOB_ID, jobId);
jobMetadata.put(CommonConstants.ControllerJob.TABLE_NAME_WITH_TYPE,
tableNameWithType);
- jobMetadata.put(CommonConstants.ControllerJob.JOB_TYPE,
ControllerJobType.RELOAD_ALL_SEGMENTS.toString());
+ jobMetadata.put(CommonConstants.ControllerJob.JOB_TYPE,
ControllerJobType.RELOAD_SEGMENT.toString());
Review Comment:
I don't think we need job type in the metadata anymore, but it is okay to
keep it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
