klsince commented on PR #10553: URL: https://github.com/apache/pinot/pull/10553#issuecomment-1504119891
@gortiz thanks for the comments. I like your idea of generating different TableConfig instances for tiers for better separation. The Index.getConfig() encapsulates a lot of details of assembling index configs from everywhere in TableConfig, so I'd +1 to reuse it than make it more complex for being aware of tier (which is the idea of current change). Below are a few points about current change, but I'll think more about your idea anyway. > ... encodingType is not actually being override, so we should also add this logic in at least another place... The current change allows to overwrite the encodingType via `FieldConfig.withTierOverwrites(tier)` > ... In these 3 new TableConfigs there is no tierOverride, so we can read indexes (and any other config!) without actually needed to know about them... The current change can use any other config as well. If tier is provided, the tier specific ones take precedence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
