gortiz commented on code in PR #10553:
URL: https://github.com/apache/pinot/pull/10553#discussion_r1165872883
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -308,6 +318,22 @@ private <C extends IndexConfig>
ColumnConfigDeserializer<C> getDeserializer(Inde
return deserializer;
}
+ private TableConfig getTableConfigWithTierOverwrites() {
+ return (_segmentTier == null || _tableConfig == null) ? _tableConfig
+ : TableConfigUtils.overwriteTableConfigForTier(_tableConfig,
_segmentTier);
+ }
+
+ private Schema inferSchema() {
+ if (_schema != null) {
+ return _schema;
+ }
+ Schema schema = new Schema();
+ for (String column : getAllKnownColumns()) {
+ schema.addField(new DimensionFieldSpec(column,
FieldSpec.DataType.STRING, true));
Review Comment:
I guess this is only going to be executed in tests, but using a random type
here looks... problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
