klsince commented on code in PR #10553:
URL: https://github.com/apache/pinot/pull/10553#discussion_r1165998811
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -308,6 +318,22 @@ private <C extends IndexConfig>
ColumnConfigDeserializer<C> getDeserializer(Inde
return deserializer;
}
+ private TableConfig getTableConfigWithTierOverwrites() {
+ return (_segmentTier == null || _tableConfig == null) ? _tableConfig
+ : TableConfigUtils.overwriteTableConfigForTier(_tableConfig,
_segmentTier);
+ }
+
+ private Schema inferSchema() {
+ if (_schema != null) {
+ return _schema;
+ }
+ Schema schema = new Schema();
+ for (String column : getAllKnownColumns()) {
+ schema.addField(new DimensionFieldSpec(column,
FieldSpec.DataType.STRING, true));
Review Comment:
yeah, I was a bit confused while seeing this. This logic was there already
and I didn't change how it's used other than moving it to this helper method.
The column names put in this dummy schema are used in some prod code. This
dummy STRING type must not. It looks like the sole purpose of this dummy schema
is to pass the column names to
FieldIndexConfigsUtil.createIndexConfigsByColName(), when _schema is null
(which can happen e.g. in MultipleTreesBuilder).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
