JeffBolle commented on code in PR #10995:
URL: https://github.com/apache/pinot/pull/10995#discussion_r1254620691
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java:
##########
@@ -46,6 +46,8 @@ public class PulsarConfig {
private final String _authenticationToken;
private final String _tlsTrustCertsFilePath;
private final boolean _enableKeyValueStitch;
+ private final boolean _populateMetadata;
+ private final boolean _populateRecordTimeFromEventTime;
Review Comment:
Pulsar has multiple timestamps associated with each message. If the user has
set the `eventTime` on their Pulsar message, that may have more meaning than
the `publishTime` assigned at the producer. The configuration parameter allows
a user to have their provided `eventTime` timestamp carried over into Pinot as
the `_recordIngestionTimeMs` value. I don't know the full effects of setting
`_recordIngestionTimeMs` to a user-provided value. Should we force this to be
set to an automatically assigned value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
