JeffBolle commented on code in PR #10995:
URL: https://github.com/apache/pinot/pull/10995#discussion_r1258321352
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java:
##########
@@ -46,6 +46,8 @@ public class PulsarConfig {
private final String _authenticationToken;
private final String _tlsTrustCertsFilePath;
private final boolean _enableKeyValueStitch;
+ private final boolean _populateMetadata;
+ private final boolean _populateRecordTimeFromEventTime;
Review Comment:
I'll remove all of the config and code for setting the record time from
event time.
From the documentation it appears that the `publishTime` field is populated
by the producer running in user code when that producer sends the `Message` to
the broker. On the `Message` interface we also have the `brokerPublishTime`,
which is documented as:
```
broker publish time from broker entry metadata, or empty if the feature is
not enabled in the broker.
```
Since the broker field is optional, should we use it if present and fall
back to the producer timestamp, or just always use the producer timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
