JeffBolle commented on code in PR #10995: URL: https://github.com/apache/pinot/pull/10995#discussion_r1258372342
########## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMessage.java: ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.stream.pulsar; + +import javax.annotation.Nullable; +import org.apache.pinot.spi.stream.StreamMessage; +import org.apache.pulsar.client.api.MessageId; + +public class PulsarStreamMessage extends StreamMessage<byte[]> { + + private final MessageId _messageId; Review Comment: The `PulsarMessageBatch` code requires a reference to the `MessageId`. The other option is to put the field in the `KafkaStreamMessageMetadata`. In the Kinesis PR the `_sequenceNumber` was stored in the `KinesisStreamMessage` for an analogous use even though it was also present in the metadata map. Regardless, to properly reconstruct the Message Id would involve: 1. Storing it as a Base64 encoded byte array 2. Re-creating it from the Base64 string in the metadata map In the conversation regarding adding objects to the metadata fields we seemed to be highly concerned with performance. Is the calling of `getNextStreamPartitionMsgOffsetAtIndex` infrequent enough that the Base64 round trip would be worth the benefit? Additionally, this would require `MessageId` to always be stored in the metadata map, requiring at least 1 of the 3 Base64 encodes. if we keep the reference in `PulsarStreamMessage` I can move the check in `PulsarMetadataExtractor` so that we are only storing the `MessageId` in metadata when `storeMetadata` is true, saving some cycles in the case when metadata extract is not enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
