navina commented on code in PR #10995: URL: https://github.com/apache/pinot/pull/10995#discussion_r1258653171
########## pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMessage.java: ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.stream.pulsar; + +import javax.annotation.Nullable; +import org.apache.pinot.spi.stream.StreamMessage; +import org.apache.pulsar.client.api.MessageId; + +public class PulsarStreamMessage extends StreamMessage<byte[]> { + + private final MessageId _messageId; Review Comment: > Is the calling of getNextStreamPartitionMsgOffsetAtIndex infrequent enough that the Base64 round trip would be worth the benefit? `getNextStreamPartitionMsgOffsetAtIndex` is called while looping through every message in the batch. > if we keep the reference in PulsarStreamMessage I can move the check in PulsarMetadataExtractor so that we are only storing the MessageId in metadata when storeMetadata is true, saving some cycles in the case when metadata extract is not enabled. Yeah. I think you should extract the `MessageId` metadata only when `storeMetadata` is true. This change should not impact existing pulsar consumers that do not enable record metadata extraction. That's my primary concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
