walterddr commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1280081624
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -115,13 +116,14 @@ public MultiStageBrokerRequestHandler(PinotConfiguration
config, String brokerId
long releaseMs =
config.getProperty(QueryConfig.KEY_OF_SCHEDULER_RELEASE_TIMEOUT_MS,
QueryConfig.DEFAULT_SCHEDULER_RELEASE_TIMEOUT_MS);
- _reducerScheduler = new OpChainSchedulerService(new
RoundRobinScheduler(releaseMs),
+ _reducerScheduler = new OpChainSchedulerService(
Executors.newCachedThreadPool(new
NamedThreadFactory("query_broker_reducer_" + _reducerPort + "_port")));
- _mailboxService = new MailboxService(_reducerHostname, _reducerPort,
config, _reducerScheduler::onDataAvailable);
+ _mailboxService = new MailboxService(_reducerHostname, _reducerPort,
config);
// TODO: move this to a startUp() function.
- _reducerScheduler.startAsync();
_mailboxService.start();
+ //TODO: make this configurable
+ _opChainExecutor = new OpChainExecutor(new
NamedThreadFactory("op_chain_worker_on_" + _reducerPort + "_port"));
Review Comment:
shoudl also set this opChainExecutor to the _reducerScheduler in line 120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
