gortiz commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1280340245
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/ReceivingMailbox.java:
##########
@@ -133,4 +152,15 @@ public void cancel() {
public int getNumPendingBlocks() {
return _blocks.size();
}
+
+ private void notifyReader() {
+ Reader reader = _reader;
+ if (reader != null) {
Review Comment:
This race condition has been fixed by adding the following invariant:
- In order to call poll, `_reader` must be not null.
I've added a `Precondition` in poll that verifies that (as long as there is
a single reader thread, which is something we assume).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
