walterddr commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1280085055
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/OpChainExecutionContext.java:
##########
@@ -62,10 +65,10 @@ public OpChainExecutionContext(MailboxService
mailboxService, long requestId, in
_traceEnabled = traceEnabled;
}
- public OpChainExecutionContext(PhysicalPlanContext physicalPlanContext) {
+ public OpChainExecutionContext(PhysicalPlanContext physicalPlanContext,
Executor executor) {
this(physicalPlanContext.getMailboxService(),
physicalPlanContext.getRequestId(), physicalPlanContext.getStageId(),
physicalPlanContext.getServer(), physicalPlanContext.getDeadlineMs(),
physicalPlanContext.getStageMetadata(),
- physicalPlanContext.getPipelineBreakerResult(),
physicalPlanContext.isTraceEnabled());
+ physicalPlanContext.getPipelineBreakerResult(),
physicalPlanContext.isTraceEnabled(), executor);
Review Comment:
nit: i was wondering if we should separate the plan context from the machine
context.
based on what i see: `mailboxService` / `executor` is machine context and
the rest of physicalPlanContext should still remain.
This should be a good start but we can clean this up further in the next
iteration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
