Jackie-Jiang commented on code in PR #11401:
URL: https://github.com/apache/pinot/pull/11401#discussion_r1300708602


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -350,6 +350,12 @@ public static class QueryOptionKey {
 
         public static final String DROP_RESULTS = "dropResults";
 
+        // Handle JOIN Overflow
+
+        public static final String MAX_ROWS_IN_JOIN = "maxRowsInJoin";
+        public static final String MAX_BYTES_IN_JOIN = "maxBytesInJoin";
+        public static final String JOIN_OVERFLOW_MODE = "joinOverflowMode";

Review Comment:
   Don't add them as query options, add them as query hint under `joinOptions`. 
See `PinotHintOptions` for more examples



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to