xiangfu0 commented on code in PR #11401:
URL: https://github.com/apache/pinot/pull/11401#discussion_r1302198230
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -228,6 +305,13 @@ private TransferableBlock
buildJoinedDataBlock(TransferableBlock leftBlock)
return new TransferableBlock(rows, _resultSchema, DataBlock.Type.ROW);
}
+ private TransferableBlock setPartialResultExceptionToBlock(TransferableBlock
block) {
Review Comment:
they are ignored right now. Need to open up another thread to fix this.
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/AbstractPlanNode.java:
##########
@@ -94,6 +94,9 @@ public NodeHint() {
public NodeHint(List<RelHint> relHints) {
_hintOptions = new HashMap<>();
+ if (relHints == null) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]