Jackie-Jiang commented on code in PR #11401:
URL: https://github.com/apache/pinot/pull/11401#discussion_r1302211791
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -83,14 +91,32 @@ public class HashJoinOperator extends MultiStageOperator {
// TODO: Remove this special handling by fixing data block EOS abstraction
or operator's invariant.
private boolean _isTerminated;
private TransferableBlock _upstreamErrorBlock;
- private KeySelector<Object[], Object[]> _leftKeySelector;
- private KeySelector<Object[], Object[]> _rightKeySelector;
+ private final KeySelector<Object[], Object[]> _leftKeySelector;
+ private final KeySelector<Object[], Object[]> _rightKeySelector;
+
+ // Below are specific parameters to protect the hash table from growing too
large.
+ // Once the hash table reaches the limit, we will throw exception or break
the right table build process.
+ /**
+ * Max rows allowed to build the right table hash collection.
+ */
+ private final int _maxRowsInHashTable;
+ /**
+ * Mode when join overflow happens, supported values: THROW or BREAK.
+ * THROW(default): Break right table build process, and throw exception,
no JOIN with left table performed.
+ * BREAK: Break right table build process, continue to perform JOIN
operation, results might be partial.
+ */
+ private final JoinOverFlowMode _joinOverflowMode;
+
+ private int _currentRowsInHashTable = 0;
+ private ProcessingException _partialResultException = null;
Review Comment:
Rename to `resourceLimitExceededException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]