gortiz commented on code in PR #11453:
URL: https://github.com/apache/pinot/pull/11453#discussion_r1308354457
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/AggregationUtils.java:
##########
@@ -90,31 +90,31 @@ private static Object mergeMax(@Nullable Object agg,
@Nullable Object value) {
}
@Nullable
- private static Boolean mergeBoolAnd(@Nullable Object agg, @Nullable Object
value) {
+ private static Object mergeBoolAnd(@Nullable Object agg, @Nullable Object
value) {
if (agg == null) {
- return (Boolean) value;
+ return value;
Review Comment:
is this logic correct? I may not have the context, but it looks like this
method tries to implement the SQL and logic. In that case `null and false` is
false, but `null and true` is null. We are not enforcing the later here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
