xiangfu0 commented on code in PR #11453:
URL: https://github.com/apache/pinot/pull/11453#discussion_r1308494786
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java:
##########
@@ -283,7 +286,7 @@ private int[] generateGroupByKeys(List<Object[]> rows, int
filterArgIndex) {
int outRowId = 0;
for (int inRowId = 0; inRowId < numRows; inRowId++) {
Object[] row = rows.get(inRowId);
- if ((Boolean) row[filterArgIndex]) {
+ if (((int) row[filterArgIndex]) == 1) {
Review Comment:
+1, stored type should provide this utility function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]