Jackie-Jiang commented on code in PR #11453:
URL: https://github.com/apache/pinot/pull/11453#discussion_r1309369553
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -192,6 +194,8 @@ private TransferableBlock produceAggregatedBlock() {
if (rows.isEmpty()) {
return TransferableBlockUtils.getEndOfStreamTransferableBlock();
} else {
+ ColumnDataType[] storedTypes =
_resultSchema.getStoredColumnDataTypes();
+ rows.forEach(row -> TypeUtils.convertRow(row, storedTypes));
Review Comment:
Let me add more comments here. This conversion is not for internal/external
type, but to solve the type difference between v1 and v2 engine. E.g. `SUM` in
v1 always return double, but might return other types in v2 (standard SQL
behavior). We use the `TypeUtils` as the bridge to convert v1 result to be used
by v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
