Jackie-Jiang commented on code in PR #11453:
URL: https://github.com/apache/pinot/pull/11453#discussion_r1309376701
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -192,6 +194,8 @@ private TransferableBlock produceAggregatedBlock() {
if (rows.isEmpty()) {
return TransferableBlockUtils.getEndOfStreamTransferableBlock();
} else {
+ ColumnDataType[] storedTypes =
_resultSchema.getStoredColumnDataTypes();
+ rows.forEach(row -> TypeUtils.convertRow(row, storedTypes));
Review Comment:
Actually I found that we do call `convertRow()` twice, once in executor and
once here.. Removing it from here since it is more clear to convert in the
executor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
